[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-30 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG142d0d3ed8e0: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target… (authored by ABataev). Repository: rG LLVM Github

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread Ye Luo via Phabricator via cfe-commits
ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM. My applications run as expected now. PR46824, PR46012, PR46868 all work fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 281690. ABataev added a comment. Fixed comment in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/ https://reviews.llvm.org/D84767 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread George Rokos via Phabricator via cfe-commits
grokos added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:659-660 // PRESENT=0x1000 | TARGET_PARAM=0x20 = 0x1020 - // MEMBER_OF_9=0x9 | PRESENT=0x1000 | FROM=0x2 | TO=0x1 = 0x91003 - // MEMBER_OF_9=0x9 |

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 281665. ABataev added a comment. Rebase + apply to global pointers only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/ https://reviews.llvm.org/D84767 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D84767#2180433 , @ye-luo wrote: > In D84767#2180280 , @ye-luo wrote: > >> This patch >> GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms >> [CUDA memcpy HtoD]

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. In D84767#2180280 , @ye-luo wrote: > This patch > GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms > [CUDA memcpy HtoD] > before the July21 change > GPU activities: 95.33% 20.317ms 4 5.0793ms

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. This patch GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms [CUDA memcpy HtoD] before the July21 change GPU activities: 95.33% 20.317ms 4 5.0793ms 1.6000us 20.305ms [CUDA memcpy HtoD] Still more transfer than it should.

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 281369. ABataev added a comment. Fixed ref count for base pointer + extra test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/ https://reviews.llvm.org/D84767 Files:

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Ye Luo via Phabricator via cfe-commits
ye-luo requested changes to this revision. ye-luo added a comment. This revision now requires changes to proceed. Please check the reproducer in https://bugs.llvm.org/show_bug.cgi?id=46868 with LIBOMPTARGET_DEBUG=1. The reference counting on the base pointer variable has side effects. It was

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: jdoerfert, ye-luo, RaviNarayanaswamy, grokos. Herald added subscribers: openmp-commits, guansong, yaxunl. Herald added projects: clang, OpenMP. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to map the