This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcb327922101b: [WebAssembly] Implement prototype
v128.load{32,64}_zero instructions (authored by tlively).
Repository:
rG LLVM Github Monorepo
tlively updated this revision to Diff 282680.
tlively added a comment.
- Renumber i32x4.dot_i16x8_s to match V8 as well
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84820/new/
https://reviews.llvm.org/D84820
Files:
tlively added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:198
+[LLVMPointerType],
+[IntrReadMem, IntrArgMemOnly, IntrSpeculatable],
+ "", [SDNPMemOperand]>;
aheejin wrote:
> Can memory accesses
tlively updated this revision to Diff 282017.
tlively added a comment.
- Remove IntrSpeculatable
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84820/new/
https://reviews.llvm.org/D84820
Files:
clang/include/clang/Basic/BuiltinsWebAssembly.def
aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:198
+[LLVMPointerType],
+[IntrReadMem, IntrArgMemOnly, IntrSpeculatable],
+
tlively added a comment.
Since this changes opcodes, it needs to be landed in concert with the
corresponding Binaryen change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84820/new/
https://reviews.llvm.org/D84820
tlively created this revision.
tlively added a reviewer: aheejin.
Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya,
jgravelle-google, sbc100, dschuff.
Herald added projects: clang, LLVM.
tlively requested review of this revision.
Specified in
