This revision was automatically updated to reflect the committed changes.
Closed by commit rGcd4e8d7f6f5e: [clangd] Fix an assertion failure in
TargetFinder's heuristic resolution of… (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
hokein added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:171
// or more declarations that it likely references.
-std::vector resolveDependentExprToDecls(const Expr *E) {
- assert(E->isTypeDependent());
+std::vector resolveExprToDecls(const Expr *E) {
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang-tools-extra/clangd/FindTarget.cpp:171
// or more declarations that it likely references.
-std::vector resolveDependentExprToDecls(const Expr *E) {
hokein created this revision.
hokein added a reviewer: nridge.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
The assertion is not true anymore after D82739
