This revision was automatically updated to reflect the committed changes.
Closed by commit rG8ce15f7eeb12: [SyntaxTree] Fix crash on pointer to member
function (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85146/new/
eduucaldas updated this revision to Diff 282814.
eduucaldas marked 2 inline comments as done.
eduucaldas added a comment.
answer comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85146/new/
https://reviews.llvm.org/D85146
Files:
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:4076-4077
+ R"cpp(
+struct X{
+ struct Y{};
+};
Please add spaces before `{`.
eduucaldas added a comment.
Additionally deleting TraverseParenTypeLoc changes nothing in the tests. I can
also investigate that, I can try to come up with a test that makes this
Traverse override relevant and if I'm not able, I would remove this override.
Comment at:
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85146
Files:
clang/lib/Tooling/Syntax/BuildTree.cpp
