[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-04 Thread Yonghong Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00602ee7ef0b: BPF: simplify IR generation for __builtin_btf_type_id() (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-03 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 282801. yonghong-song added a comment. add a test case in clang where testing type existence of a named struct and the typedef of that named struct will result in different IR intrinsic func arguments which will prevent CSE which may lose one of

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-03 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. In D85174#2192269 , @ast wrote: > Is it a cleanup or is it a fix for some bug? If latter there should be a new > test for it? This is also to fix the CSE issue where two builtins are CSE'ed if one has type "struct t" and

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-03 Thread Andrii Nakryiko via Phabricator via cfe-commits
anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. Tested locally. Previously failing tests are now passing. All recorded relocations look correct. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-03 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added a comment. Is it a cleanup or is it a fix for some bug? If latter there should be a new test for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85174/new/ https://reviews.llvm.org/D85174

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-03 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. yonghong-song added a project: clang. Herald added subscribers: llvm-commits, cfe-commits, JDevlieghere, hiraditya. Herald added a project: LLVM. yonghong-song requested review of this revision. This patch