[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL closed this revision. ShuhongL added a comment. Landed by commit: rGb129c9d81aff8ece71eb29df1e5f31136a48c040 (Sorry, I didn't properly align the tags in commit message and hence this revision was not automatically

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL updated this revision to Diff 284357. ShuhongL added a comment. Fixed indent and updated error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor edits. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:213 + + llvm_unreachable("unexpected c++ library type, only libc++ is

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL updated this revision to Diff 283988. ShuhongL added a comment. Added test cases for fatal error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:210 + case ToolChain::CST_Libstdcxx: +llvm::report_fatal_error("linking libstdc++ unimplemented on AIX"); + } Should there be a test for the error message?

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL updated this revision to Diff 283607. ShuhongL added a comment. Added testcases for lc and lc++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 Files: clang/lib/Driver/ToolChains/AIX.cpp