[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

2020-08-06 Thread Aleksandr Platonov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86711668330c: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was… (authored by ArcsinX). Repository: rG LLVM Github Mon

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

2020-08-06 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-bad-signal-to-kill-thread-undef-sigterm.cpp:1 +// RUN: clang-tidy %s --checks="-*,bugprone-bad-signal-to-kill-thread" + hokein wrote: > nit: `// RUN: clang-tidy %s -ch

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

2020-08-06 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX updated this revision to Diff 283503. ArcsinX added a comment. Fix test according to review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85401/new/ https://reviews.llvm.org/D85401 Files: clang-tools-extra/clang-tidy/bugprone/Bad

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

2020-08-06 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-bad-signal-to-kill-thread-undef-sigterm.cpp:1 +// RUN: clang-tidy %s --checks="-*,bugprone-bad-signal-to-

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

2020-08-05 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, xazax.hun. Herald added a project: clang. ArcsinX requested review of this revision. `PP->getMacroInfo()` returns nullptr for undefined macro, which leads to null-dereference at `MI->tockens()