[PATCH] D85485: Fix quiet mode in git-clang-format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG294e1900f281: Fix quiet mode in git-clang-format (authored by Gvald, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille added a comment. I'll need a contact email to preserve authorship information, can you send me one at `sguel...@redhat.com`? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 __

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Sure, thanks for your patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 ___ c

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald added a comment. @serge-sans-paille - the diff is PEP8 compliant now. Care to commit, as I don't have the right permissions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 ___

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald marked an inline comment as done. Gvald added a comment. Tried to `arc land` but don't have the permissions. From LLVM docs : > It is sufficient to add a comment to the approved review indicating you > cannot commit the patch your

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald updated this revision to Diff 286531. Gvald edited the summary of this revision. Gvald added a project: clang-format. Gvald added a comment. PEP8 compliance fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-format/git-clang-format:151 if not changed_lines: -print('no modified files to format') +if opts.verbose >=

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald added reviewers: jmerdich, rsmith, djasper, serge-sans-paille. Gvald added a comment. Quiet mode is very useful for scripting, when only the diff format output is required, or no output if not formatting is needed. In case of no modified files, git-clang-format will output to screen even t

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Gvald requested review of this revision. Eliminate output in quiet mode, when no modified files exists Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85485 Files: clang/tools/