[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

This revision was automatically updated to reflect the committed changes. Closed by commit rGfef260712407: [Sema] Use the proper cast for a fixed bool enum. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 ___

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante updated this revision to Diff 285685. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 Files: clang/lib/Sema/SemaCast.cpp clang/test/CXX/drs/dr23xx.cpp

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump %s | FileCheck %s + rsmith wrote: > I don't

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

rsmith added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump %s | FileCheck %s + I don't think we really need a dedicated AST test for this. Such tests

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante updated this revision to Diff 284478. Mordante added a comment. Addresses the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 Files: clang/lib/Sema/SemaCast.cpp clang/test/AST/ast-dump-enum-bool.cpp

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json %s | FileCheck %s + rsmith wrote: > aaron.ballman

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

rsmith added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json %s | FileCheck %s + aaron.ballman wrote: > riccibruno wrote: > > Why a (pretty unreadable) json

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json %s | FileCheck %s + riccibruno wrote: > Why a (pretty unreadable) json test? There is also

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

riccibruno added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json %s | FileCheck %s + Why a (pretty unreadable) json test? There is also `make-ast-dump-check.sh`

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante created this revision. Mordante added reviewers: aaron.ballman, dblaikie, rsmith. Mordante added a project: clang. Herald added a subscriber: dexonsmith. Mordante requested review of this revision. When casting an enumerate with a fixed bool type the casting should use an