[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

2020-08-12 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D85710#2212174 , @rjmccall wrote: > I always imagined that we'd implement this by just inverting the emission: > emit the RHS of the assignment and then pass a callback down to a function > that descended into conditional opera

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

2020-08-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I always imagined that we'd implement this by just inverting the emission: emit the RHS of the assignment and then pass a callback down to a function that descended into conditional operators and called the callback when it hit a leaf. Having an LValue case that's an

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

2020-08-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 284594. rsmith added a comment. - Remove development aid from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85710/new/ https://reviews.llvm.org/D85710 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/C

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

2020-08-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. rsmith requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. C++ permits use of (cond ? x.a : y.b) as an