hokein updated this revision to Diff 287025.
hokein marked an inline comment as done.
hokein added a comment.
simplify the testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85716/new/
https://reviews.llvm.org/D85716
Files:
clang/lib/AST/Ex
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG466590192b42: [AST][RecoveryExpr] Fix a bogus unused
diagnostic when the type is preserved. (authored by hokein).
Repository:
rG LLVM Github Monor
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/SemaCXX/recovery-expr-type.cpp:80
+namespace test6 {
+struct Base {
+private:
nit: can the testcase be simplified?
Isn't `st
hokein added inline comments.
Comment at: clang/test/SemaCXX/recovery-expr-type.cpp:88
+void func() {
+ // verify that no -Wunused-variable diagnostic on the inner Derived
expression.
+ (Derived(Derived())); // expected-error {{call to implicitly-deleted default
constructor}}
hokein updated this revision to Diff 284742.
hokein added a comment.
address review comment:
a dependent-kind cast expr should not be warned about the unused result.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85716/new/
https://reviews.llvm.org/
sammccall added inline comments.
Comment at: clang/lib/Sema/SemaStmt.cpp:353
return;
+if (isa(E))
+ return;
This seems like a very specific patch to a special case of a potentially more
general problem...
Comment at: clang/test
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a project: clang.
hokein requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85716
Files:
clang/lib/Sema/SemaStmt.cpp
clang/test/SemaCXX/recovery-expr-type.cpp
Inde
