[PATCH] D85819: [SyntaxTree] Split tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1211fd1ec03: [SyntaxTree] Split tests for expressions (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D85819?vs=28527

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added a comment. We'll split this file in a future change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1546-1548 +unsigned operator "" _r(const char*); +template +unsigned operator "" _t(); eduucaldas wrote: > Same setup for `FloatUserDefinedLiteral`. I think it is justified

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2805 -TEST_P(SyntaxTreeTest, UserDefinedBinaryOperator) { +TEST_P(SyntaxTreeTest, UserDefinedOperator_Assignment) { if (!GetParam().isCXX()) { gribozavr2 wrote: > UserD

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285273. eduucaldas marked 11 inline comments as done. eduucaldas added a comment. Answer review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: cla

[PATCH] D85819: [SyntaxTree] Split tests

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Please also consider splitting the file into multiple. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1238 +namespace n { +template +struct ST {

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1005 + +TEST_P(SyntaxTreeTest, QualifiedIdWithNamespace) { + if (!GetParam().isCXX()) { Here I didn't merely split the tests, I also changed them a bit. PTAL. ==

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285071. eduucaldas added a comment. Rename tests following `TestSuite_TestCase` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: clang/unittests/Tooling/Synt

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285070. eduucaldas added a comment. - [SyntaxTree] Split tests for `QualifiedId` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: clang/unittests/Tooling/Syn

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285035. eduucaldas added a comment. Split tests for `UserDefinedLiteral` Split tests for `NumericUserDefinedLiteral` Split tests for `NestedBinaryOperator` Split tests for `UserDefinedBinaryOperator` Split tests for `UserDefinedPrefixOperator` Repository:

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added a comment. Before we had an UnqualifiedId test that tested for everything in the grammar . Now we just split this test and test the alternatives separately. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:6

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We do that because: - Big tests generated big tree dumps that could hardly serve as documentation. - In most cases the tests didn't share setup, t