[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

hans added a comment. In D86091#2296576 , @mati865 wrote: > @hans sorry for not spotting it earlier but is it possible to still backport > it to LLVM 11? > It's totally OK if it's too late. I can easily keep it as a patch in MSYS2 > repository. I'd

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

mati865 added subscribers: hans, mati865. mati865 added a comment. @hans sorry for not spotting it earlier but is it possible to still backport it to LLVM 11? It's totally OK if it's too late. I can easily keep it as a patch in MSYS2 repository. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM (looks like the other example plugins just use PRIVATE as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86091/new/

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

krisb created this revision. krisb added a reviewer: john.brawn. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. krisb requested review of this revision. Seems '${cmake_2_8_12_PRIVATE}' was removed long time ago, so it should be just PRIVATE keyword here.