[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

This revision was automatically updated to reflect the committed changes. Closed by commit rGba32915db2ce: [SyntaxTree] Add support for `MemberExpression` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D86227?vs=286811&id=286820#toc Repository: rG LLVM Github Mon

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286811. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Unify logic for generating `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:911 + S->getEndLoc()), + idExpression, nullptr); + ---

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:900 + +auto *unqualifiedId = new (allocator()) syntax::UnqualifiedId; +Builder.foldNode(Builder.getRange(S->getMemberLoc(), S->getEndLoc()), -

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286799. eduucaldas marked 10 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/i

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286762. eduucaldas added a comment. Implicit `MemberExpr` generates `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/include/clang/Tool

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:180 + MemberExpression_member, + MemberExpression_accessToken, }; Could you order new items in source order? object, access token, member. Comment at: c

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:333 +/// expression . template_opt id-expression +/// id-expression +/// e.g. `x.a`, `xp->a` or even just `a` when we have an implicit `this->`.

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286593. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn