atrosinenko added a comment.
Uploaded because it was already approved and no other review comments received
since then. Anyway, please feel free to request followup changes if needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86289/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfce035eae980: [NFC][compiler-rt] Factor out __mulo[sdt]i4
implementations to .inc file (authored by atrosinenko).
Changed prior to commit:
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM, but let's give others a chance to comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86289/new/
https://reviews.llvm.org/D86289
atrosinenko updated this revision to Diff 287032.
atrosinenko added a comment.
Explicitly mark .inc file as a C source like is already done for almost all
`*_impl.inc` files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86289/new/
atrosinenko created this revision.
atrosinenko added reviewers: MaskRay, kamleshbhalui, luismarques, efriedma,
aykevl.
Herald added subscribers: Sanitizers, dberris.
Herald added a project: Sanitizers.
atrosinenko requested review of this revision.
The existing implementations are almost
