[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

dang added a comment. Yes of course. This is a prerequisite for some other changes that are waiting to land and need polishing. Thanks for doing the revert. I will investigate the failures and recommit it when appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

teemperor added a comment. Just to also jump in on the thread: This broke the modules builds. I fixed that in https://reviews.llvm.org/rGe0e7eb2e2648aee83caf2ecfe2972ce2f653d306 so please recommit that patch or merge it into this revision before relanding. Thanks! Repository: rG LLVM

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

rupprecht added a comment. Thanks for the revert. In addition to the one eabi test, we saw widespread msan use-of-uninitialized-value errors from here: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Target/ARM/ARMTargetMachine.cpp#L229. I think it would explain the eabi test

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

dyung added a comment. I have reverted this change in 8d2d0e84857cb1f2d01456eb433b5172d3a0772b to get the build bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

thakis added a comment. Looks like this broke tests on windows: http://45.33.8.238/win/23171/step_7.txt Please take a look, and if it takes a while to fix, please revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86290/new/

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86290/new/ https://reviews.llvm.org/D86290