nickdesaulniers planned changes to this revision.
nickdesaulniers added inline comments.
Comment at: clang/docs/LanguageExtensions.rst:2422
+* ``vprintf``
+* ``vsprintf``
+
Let me triple check the docs look good.
Repository:
rG LLVM Github Monorepo
CHANGES
nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:513
BUILTIN(__builtin_printf, "icC*.", "Fp:0:")
+BUILTIN(__builtin_putchar, "ii", "F")
+BUILTIN(__builtin_puts, "icC*", "nF")
nickdesaulniers updated this revision to Diff 289572.
nickdesaulniers added a comment.
- add putc and fputc builtins
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86508/new/
https://reviews.llvm.org/D86508
Files:
nickdesaulniers added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:513
BUILTIN(__builtin_printf, "icC*.", "Fp:0:")
+BUILTIN(__builtin_putchar, "ii", "F")
+BUILTIN(__builtin_puts, "icC*", "nF")
nickdesaulniers wrote:
> nickdesaulniers
nickdesaulniers added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:513
BUILTIN(__builtin_printf, "icC*.", "Fp:0:")
+BUILTIN(__builtin_putchar, "ii", "F")
+BUILTIN(__builtin_puts, "icC*", "nF")
nickdesaulniers wrote:
> nickdesaulniers
nickdesaulniers added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:513
BUILTIN(__builtin_printf, "icC*.", "Fp:0:")
+BUILTIN(__builtin_putchar, "ii", "F")
+BUILTIN(__builtin_puts, "icC*", "nF")
nickdesaulniers wrote:
> rsmith wrote:
> >
nickdesaulniers updated this revision to Diff 289312.
nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.
- rebase on master, precommitted getLangOpts() change, dropped p7.cpp test
change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
nickdesaulniers added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:513
BUILTIN(__builtin_printf, "icC*.", "Fp:0:")
+BUILTIN(__builtin_putchar, "ii", "F")
+BUILTIN(__builtin_puts, "icC*", "nF")
rsmith wrote:
> aaron.ballman wrote:
> >
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:488
+BUILTIN(__builtin_calloc, "v*zz", "F")
+BUILTIN(__builtin_exit, "vi", "Fr")
BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:")
rsmith wrote:
> aaron.ballman wrote:
> >
rsmith added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:488
+BUILTIN(__builtin_calloc, "v*zz", "F")
+BUILTIN(__builtin_exit, "vi", "Fr")
BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:")
aaron.ballman wrote:
> Should we be adding
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Builtins.def:488
+BUILTIN(__builtin_calloc, "v*zz", "F")
+BUILTIN(__builtin_exit, "vi", "Fr")
BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:")
Should we be adding `atexit()` as well?
rsmith added a comment.
LGTM
I've not checked all the types are correct (someone should double-check that
prior to commit), but it looks like GCC provides these `__builtin_*` functions,
so we should too. The addition of the non-`__builtin_` versions should improve
our diagnostics but
nickdesaulniers added a comment.
bumping for review. Are there additional reviewers we could add to share the
burden?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86508/new/
https://reviews.llvm.org/D86508
nickdesaulniers updated this revision to Diff 287573.
nickdesaulniers added a comment.
- misuploaded
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86508/new/
https://reviews.llvm.org/D86508
Files:
clang/docs/LanguageExtensions.rst
14 matches
Mail list logo