nickdesaulniers added inline comments.
Comment at: clang/docs/LanguageExtensions.rst:2370
+* ``bcmp``
* ``memchr``
nickdesaulniers wrote:
> rsmith wrote:
> > aaron.ballman wrote:
> > > Can you mention the deprecation issue here?
> > Do we really provide
rsmith added a comment.
It seems to me that adding new `__builtin_*` functions for GCC compatibility
and adding new `LIBBUILTIN`s are unrelated changes, and it might be clearer to
split them up into two commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rsmith added inline comments.
Comment at: clang/docs/LanguageExtensions.rst:2370-2398
+* ``bcmp``
* ``memchr``
-* ``memcmp`` (and its deprecated BSD / POSIX alias ``bcmp``)
+* ``memcmp``
+* ``memcpy``
+* ``memmove``
+* ``memset``
+* ``strcat``
aaron.ballman
aaron.ballman added a comment.
This looks reasonable to me.
Comment at: clang/docs/LanguageExtensions.rst:2370
+* ``bcmp``
* ``memchr``
Can you mention the deprecation issue here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
nickdesaulniers added a comment.
Ok, this is ready for review. I plan to review the newer C standards than ISO
C90 in follow up patches, so I'll likely be touching these file more. Figuring
out a more maintainable sort order in particular is an itch I'd like to scratch.
Repository:
rG
nickdesaulniers updated this revision to Diff 289594.
nickdesaulniers added a comment.
- improve docs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86508/new/
https://reviews.llvm.org/D86508
Files:
clang/docs/LanguageExtensions.rst
