This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc3d4743277b: [SyntaxTree] Migrate `ParamatersAndQualifiers`
to use the new List API (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
eduucaldas updated this revision to Diff 288010.
eduucaldas added a comment.
Add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86600/new/
https://reviews.llvm.org/D86600
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:4041
+template
+[[void test(T , Args... );]]
+)cpp",
Could you also add one with a n
eduucaldas updated this revision to Diff 287947.
eduucaldas added a comment.
answer code-review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86600/new/
https://reviews.llvm.org/D86600
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
gribozavr2 added a comment.
Could you add some tests with variadic parameter lists & variadic function
templates? If we don't handle them correctly, please leave a FIXME in the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86600/new/
https:/
gribozavr2 added a comment.
I think we also need to update `List::getTerminationKind()` and other similar
List methods to handle this list kind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86600/new/
https://reviews.llvm.org/D86600
eduucaldas updated this revision to Diff 287889.
eduucaldas added a comment.
nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86600/new/
https://reviews.llvm.org/D86600
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Synt
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D86600
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syn