gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:156 // Roles specific to particular node kinds. - OperatorExpression_operatorToken, - UnaryOperatorExpression_operand, - BinaryOperatorExpression_leftHandSide, - BinaryOperatorExpression_rightHandSide, - CaseStatement_value, - IfStatement_thenStatement, - IfStatement_elseKeyword, - IfStatement_elseStatement, - ReturnStatement_value, - ExpressionStatement_expression, - CompoundStatement_statement, - StaticAssertDeclaration_condition, - StaticAssertDeclaration_message, - SimpleDeclaration_declarator, - TemplateDeclaration_declaration, - ExplicitTemplateInstantiation_declaration, - ArraySubscript_sizeExpression, - TrailingReturnType_declarator, - ParametersAndQualifiers_parameters, - ParametersAndQualifiers_trailingReturn, - IdExpression_id, - IdExpression_qualifier, - ParenExpression_subExpression, - MemberExpression_object, - MemberExpression_accessToken, - MemberExpression_member, - CallExpression_callee, - CallExpression_arguments, + // OperatorExpression + OperatorToken, ---------------- I'd suggest to remove the cross-references in the comments. In my experience, one is much better off using "find references" in the IDE. The comments can (and do) rapidly become stale. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86636/new/ https://reviews.llvm.org/D86636 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits