This revision was automatically updated to reflect the committed changes.
Closed by commit rGd70e05c9e36a: [clang-format] Parse double-square attributes
as pointer qualifiers (authored by arichardson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86721/new/
https://reviews.llvm.org/D86721
arichardson updated this revision to Diff 289118.
arichardson added a comment.
add test case with argument
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86721/new/
https://reviews.llvm.org/D86721
Files:
clang/lib/Format/TokenAnnotator.cpp
aaron.ballman added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:8071
verifyIndependentOfContext("MACRO(A *__attribute((foo)) a);");
+ verifyIndependentOfContext("MACRO(A *[[clang::attr]] a);");
verifyIndependentOfContext("MACRO('0' <= c && c <=
arichardson updated this revision to Diff 288564.
arichardson added a comment.
drop unnecesssary const
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86721/new/
https://reviews.llvm.org/D86721
Files:
clang/lib/Format/TokenAnnotator.cpp
arichardson created this revision.
arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall,
curdeius, aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
arichardson requested review of this revision.
Before: x = (foo *[[clang::attr]] const) * v;