This revision was automatically updated to reflect the committed changes.
Closed by commit rG81aa66f65f50: Extract infrastructure to ignore intermediate
expressions into… (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
eduucaldas updated this revision to Diff 288978.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
Answer comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86778/new/
https://reviews.llvm.org/D86778
Files:
eduucaldas updated this revision to Diff 288965.
eduucaldas added a comment.
Fix lint problems
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86778/new/
https://reviews.llvm.org/D86778
Files:
clang/include/clang/AST/IgnoreExpr.h
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/AST/IgnoreExpr.h:15
+namespace clang {
+namespace {
+/// Given an expression E and functions Fn_1,...,Fn_n : Expr * -> Expr *,
eduucaldas updated this revision to Diff 288963.
eduucaldas added a comment.
Herald added a subscriber: mgorny.
Minor lint fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86778/new/
https://reviews.llvm.org/D86778
Files:
gribozavr2 added a comment.
> This allows users to use IgnoreExprNodes outside of clang/AST/Expr.h
Did you mean "outside of Expr.cpp"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86778/new/
https://reviews.llvm.org/D86778
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
This allows users to use `IgnoreExprNodes` outside of `clang/AST/Expr.h`
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D86778
