[PATCH] D86820: [X86] Add a /tune: option for clang-cl

2020-09-02 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca134374b74e: [X86] Add a /tune: option for clang-cl (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

2020-09-02 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86820/new/ https://reviews.llvm.org/D86820 ___ cfe-commits mailing list

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

2020-09-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 289273. craig.topper added a comment. Use an alias. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86820/new/ https://reviews.llvm.org/D86820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-x86-flags.c Index:

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

2020-09-01 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Okay, adding it to clang-cl seems fine to me. But I think it could be a simple alias? Comment at: clang/include/clang/Driver/Options.td:4693 HelpText<"Set architecture for code generation">; +def _SLASH_tune : CLCompileJoined<"tune:">, +

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

2020-08-31 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D86820#2247336 , @hans wrote: > Would it be enough for users to specify /clang:-mtune instead? How does icc > spell its option? I didn't know you could spell it as /clang:-mtune. ICC has /tune: according to this

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

2020-08-31 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Would it be enough for users to specify /clang:-mtune instead? How does icc spell its option? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86820/new/ https://reviews.llvm.org/D86820 ___ cfe-commits mailing list

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

2020-08-28 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: rnk, thakis, hans, echristo, erichkeane. Herald added subscribers: dang, danielkiss. craig.topper requested review of this revision. We recently added support for -mtune. This patch adds /tune: so we can specify the tune CPU from