[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG272742a92d24: Perform an extra consistency check when searching ModuleManagers (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Assuming that it works, this seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86823/new/ https://reviews.llvm.org/D86823

[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

CodaFi updated this revision to Diff 288734. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86823/new/ https://reviews.llvm.org/D86823 Files: clang/lib/Serialization/ModuleManager.cpp Index: clang/lib/Serialization/ModuleManager.cpp

[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

aprantl added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:152 + const FileEntry *Entry) -> bool { +if (Kind != MK_ImplicitModule) { + return true; nit: LLVM style omits curly braces on

[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

CodaFi created this revision. CodaFi added reviewers: vsapsai, aprantl, doug.gregor. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. CodaFi requested review of this revision. The ModuleManager's use of FileEntry nodes as the keys for its map of loaded modules is