[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

sberg added a comment. Herald added a project: All. In D86881#2777808 , @arphaman wrote: > Hey, thanks for following up on this PR. I've done some more digging and I > think we can remove this Darwin-specific workaround in the near future. I'm > hoping

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

arphaman added a comment. Hey, thanks for following up on this PR. I've done some more digging and I think we can remove this Darwin-specific workaround in the near future. I'm hoping to provide an update in the next few weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

MaskRay added a comment. Agreed. This feels like a workaround. Can the offending projects be fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86881/new/ https://reviews.llvm.org/D86881 ___

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

jyknight added a comment. But this (re-)breaks the functionality of -fvisibility-inlines-hidden on Darwin. That seems bad? I'd've liked to see more of an explanation as to why this was considered a necessary breakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGd46f2c51e4c8: Make -fvisibility-inlines-hidden apply to static local variables in inline… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: dang, ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. This effectively disables https://reviews.llvm.org/D50968 on Darwin, and provides a command line