[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-10-07 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. In D86959#2316351 , @arichardson wrote: > In D86959#2313631 , @sammccall wrote: > >> Sorry to be really late here, but this patch regressed some macro >> definitions like: >> >>

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-10-07 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. In D86959#2313631 , @sammccall wrote: > Sorry to be really late here, but this patch regressed some macro definitions > like: > > #define lambda [](const decltype(x) ) {} > > which now formats as > > #define lambda

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-10-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Sorry to be really late here, but this patch regressed some macro definitions like: #define lambda [](const decltype(x) ) {} which now formats as #define lambda [](const decltype(x) & ptr) {} (extra space around ampersand) It looks like the generalization of

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-09-07 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG56fa7d1dc6a8: [clang-format] Fix formatting of _Atomic() qualifier (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D86959?vs=289509=290211#toc Repository: rG LLVM Github

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-09-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86959/new/ https://reviews.llvm.org/D86959

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-09-02 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson updated this revision to Diff 289509. arichardson added a comment. - fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86959/new/ https://reviews.llvm.org/D86959 Files: clang/lib/Format/FormatToken.cpp

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-09-02 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson updated this revision to Diff 289405. arichardson added a comment. - use valid C++ syntax in the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86959/new/ https://reviews.llvm.org/D86959 Files:

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

2020-09-01 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. Before: _Atomic(uint64_t) * a; After: _Atomic(uint64_t)