This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a3c82e85b73: [clang-format][NFC] Store FormatToken::Type as
an enum instead of bitfield (authored by arichardson).
Repository:
rG LLVM Github
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
Assuming it builds with minimum required c++ compiler
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87006/new/
MyDeveloperDay added a comment.
I'm not a C++ language lawyer so I'm not sure which standard introduce enum
inheritance? (maybe its something we could always do?), if its a recent change
we just need to ensure we are conforming to the C++ version that is needed to
build clang.
Apart from that
arichardson updated this revision to Diff 289403.
arichardson added a comment.
- remove unncessary cast+check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87006/new/
https://reviews.llvm.org/D87006
Files:
clang/lib/Format/FormatToken.h
arichardson created this revision.
arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall,
curdeius.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
arichardson requested review of this revision.
This improves the debugging experience since LLDB will print
