[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

2020-09-07 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2427 + // inside a function this should always be treated as a variable. + return CouldBeTypeList && Line.Level == 0; } MyDeveloperDay wrote: > how hard would it be to do the

[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

2020-09-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Thanks for the patch, I think this looks like a comprehensive improvement, a new nits only Comment at: clang/lib/Format/TokenAnnotator.cpp:2427 + // inside a function this should always be treated as a variable. + return CouldBeTypeList &&

[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

2020-09-02 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson updated this revision to Diff 289508. arichardson added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87028/new/ https://reviews.llvm.org/D87028 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

2020-09-02 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. This change also comma-separated identifiers inside