This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaaf1a96408b1: [DebugInfo] Add size to class declarations in
debug info. (authored by akhuang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035
+ const RecordDecl *D = RD->getDefinition();
+ if (D && D->isCompleteDefinition())
+Size = CGM.getContext().getTypeSize(Ty);
akhuang wrote:
> dblaikie wrote:
> > When is a
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87062/new/
https://reviews.llvm.org/D87062
akhuang updated this revision to Diff 289768.
akhuang added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87062/new/
https://reviews.llvm.org/D87062
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
akhuang updated this revision to Diff 289602.
akhuang marked an inline comment as done.
akhuang added a comment.
remove assert; edit test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87062/new/
https://reviews.llvm.org/D87062
Files:
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035
+ const RecordDecl *D = RD->getDefinition();
+ if (D && D->isCompleteDefinition())
+Size = CGM.getContext().getTypeSize(Ty);
dblaikie wrote:
> When is a definition not a
dblaikie added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035
+ const RecordDecl *D = RD->getDefinition();
+ if (D && D->isCompleteDefinition())
+Size = CGM.getContext().getTypeSize(Ty);
When is a definition not a complete definition?
akhuang created this revision.
akhuang added reviewers: aprantl, dblaikie.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
akhuang requested review of this revision.
Herald added a subscriber: ormris.
This adds the size to forward declared class
