[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbb3baf6205c: Thread safety analysis: Improve documentation for scoped capabilities (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D87066?vs=289826=290145#toc

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Ah, this reads more clearly to me, thank you for the additional changes. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaronpuchert updated this revision to Diff 289826. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. - More detailed description how scoped capabilities work. - Make the comment wording more consistent with existing comments and the previous explanation. - Properly

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaronpuchert added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:908 +// Assumes mu is held, implicitly acquires *this and connects it to mu. +MutexLocker(t_mutex , adopt_lock_t) REQUIRES(mu) : mut(mu) {} + `s/t_mutex/Mutex/g`

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaron.ballman added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:922 +// Releases *this and all underlying capabilities, if they are still held. +// There is no warning on double unlock. ~MutexLocker() RELEASE() { This makes it

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaronpuchert added a comment. Not sure about the added comments, I can also remove them if they're not helpful. @aaron.ballman, this addresses your earlier comment D81332#2079489 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert requested review of this revision. They are for more powerful than the current documentation implies, this adds - adopting a lock,