[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51c5add8547a: Extending Baremetal toolchains support for the rtlib option. (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco added a comment. @jroelofs yes please :p After you mentioned it, I rechecked the guidelines and read: > Once a patch has been reviewed and approved on Phabricator it can then be > committed to trunk. If you do not have commit access, someone has to commit > the change for you (with

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. btw, do you need me to commit it for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Yeah, this should do what you're after. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco marked an inline comment as done. mcarrasco added a comment. Great! Thanks a lot for your answer @jroelofs !! Then, do you think this current proposal to BareMetal.cpp is enough? Best, Manuel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. In D87164#2268366 , @mcarrasco wrote: > @jroelofs no worries, thanks a lot for your time. > > Please tell me if I understood you correctly. > > It is acceptable just to append the -lgcc if -rtlib=libgcc is used, although > the

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco marked an inline comment as done. mcarrasco added a comment. @jroelofs no worries, thanks a lot for your time. Please tell me if I understood you correctly. It is acceptable just to append the -lgcc if -rtlib=libgcc is used, although the user is responsible to ensure that correct

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco updated this revision to Diff 291262. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp Index: clang/test/Driver/baremetal.cpp

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. > The Baremetal toolchain currently has a fixed behavior regardless of the > -rtlib option's value. It is always linking against compiler-rt unless > -nodefaultlibs is enabled. > > This proposal slightly changes the code in such a way that enabling > -rtlib=libgcc

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco created this revision. mcarrasco added reviewers: jroelofs, clang. mcarrasco added a project: clang-modules. Herald added subscribers: cfe-commits, abidh, kristof.beyls. Herald added a project: clang. mcarrasco requested review of this revision. The Baremetal toolchain currently has a