[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7586afc4dcd: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp (authored by martong). Changed prior to commit:

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D87239#2259428 , @martong wrote: > So, the problem is rather that the constraint check should be done in > checkPreCall, but that should be in

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

martong added a comment. @steakhal Ping. > I completely agree with you. So, how should we proceed? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87239/new/ https://reviews.llvm.org/D87239 ___

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

martong marked an inline comment as done. martong added a comment. In D87239#2259345 , @steakhal wrote: > I completely agree with you. > I plan to further refactor the CStringChecker, but the related patches are > pretty much stuck :D > > I think this

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

steakhal added a comment. I completely agree with you. I plan to further refactor the CStringChecker, but the related patches are pretty much stuck :D I think this workaround is fine for now. You might as well extend the corresponding parts of the CStringChecker to make the modelling more

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

martong created this revision. martong added reviewers: Szelethus, balazske, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald