[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

2023-04-03 Thread Min-Yih Hsu via Phabricator via cfe-commits
myhsu abandoned this revision. myhsu added a comment. Herald added subscribers: wlei, ormris, MaskRay. Herald added a project: All. just realized I haven't updated this patch for years. I'll come up with an up-to-date version when I have time. CHANGES SINCE LAST ACTION

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

2020-09-10 Thread Renato Golin via Phabricator via cfe-commits
rengolin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2021 + +Adds ``optnone`` attributes to functions whose instrumentation-based PGO profiling counts are equal to zero (i.e. "cold"). + Following discussions in the mailing list,

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

2020-09-09 Thread Min-Yih Hsu via Phabricator via cfe-commits
myhsu updated this revision to Diff 290849. myhsu edited the summary of this revision. myhsu added a comment. Unified driver options from "-fprofile-deopt-cold-*" into "-fprofile-omit-cold-opt" and "-fprofile-omit-cold-opt=". Where the former one is just a shorthand of

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

2020-09-09 Thread Min-Yih Hsu via Phabricator via cfe-commits
myhsu updated this revision to Diff 290769. myhsu added a comment. Fix a bug in driver that accidentally made this feature turn on by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87338/new/ https://reviews.llvm.org/D87338 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

2020-09-08 Thread Min-Yih Hsu via Phabricator via cfe-commits
myhsu created this revision. myhsu added reviewers: rsmith, bogner, xur. Herald added subscribers: cfe-commits, wenlei, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. myhsu requested review of this revision. Following up https://reviews.llvm.org/D87337 . This patch add