[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. In D87470#2273310 , @junparser wrote: > @lxfind , could you backport this to branch 11? I am actually seeing some problems with this change. Still investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

junparser added a comment. Herald added a subscriber: modimo. @lxfind , could you backport this to branch 11? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf477db5f9e0: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle (authored by lxfind). Repository: rG LLVM Github

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. In D87470#2268911 , @rjmccall wrote: > Thanks, LGTM. Thank you for reviewing and the suggestions on testcase! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind updated this revision to Diff 291324. lxfind added a comment. remove asan option, not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files: clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind updated this revision to Diff 291321. lxfind added a comment. Add test to verify that lifetime.end appears right after the address call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files:

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

rjmccall added a comment. In D87470#2268267 , @lxfind wrote: > hmm @rjmccall, I don't think there is a stable way to test this. The code > generated for symmetric transfer is way too complicated to stably pattern > match one less item in the frame. I

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind updated this revision to Diff 291255. lxfind added a comment. Remove unstable test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files: clang/lib/Sema/SemaCoroutine.cpp Index:

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. hmm @rjmccall, I don't think there is a stable way to test this. The code generated for symmetric transfer is way too complicated to stably pattern match one less item in the frame. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind updated this revision to Diff 291140. lxfind added a comment. Add test case. Verify that the size of the frame reduced by 8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files:

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

rjmccall added a comment. Also LGTM with a testcase. It's fine to test the result of IRGen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___ cfe-commits

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. In D87470#2267060 , @junparser wrote: > Thanks for the change. LGTM, and testcase？ Not sure how to add a test case for this though. We don't seem to explicitly test AST output. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

junparser added a comment. Thanks for the change. LGTM, and testcase？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___ cfe-commits mailing list

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind created this revision. lxfind added reviewers: lewissbaker, wenlei, hoy, bruno, junparser, rjmccall. Herald added subscribers: cfe-commits, dexonsmith, modocache. Herald added a project: clang. lxfind requested review of this revision. In generating the code for symmetric transfer, a