[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a01d9498a7: Sema: add support for `__attribute__((__swift_bridge__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87532?vs=292018=292273#toc Repository: rG LLVM

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/Attr.td:2134 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; + let Args =

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd updated this revision to Diff 292018. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87532/new/ https://reviews.llvm.org/D87532 Files: clang/include/clang/Basic/Attr.td

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2134 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; + let Args = [StringArgument<"SwiftType">]; aaron.ballman wrote: >

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2134 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; + let Args = [StringArgument<"SwiftType">]; Is it intentional that this is `swift_bridge` but we just

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2133 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; aaron.ballman wrote: > Is this a type or a declaration attribute? It looks like a declaration > attribute

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd updated this revision to Diff 291601. compnerd marked an inline comment as done. compnerd added a comment. Address some feedback from @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87532/new/ https://reviews.llvm.org/D87532

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd marked 4 inline comments as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5535 + // Don't duplicate annotations that are already set. + if (D->hasAttr()) { +S.Diag(AL.getLoc(), diag::warn_duplicate_attribute) <<

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2137 + let Subjects = SubjectList<[Tag, TypedefName, ObjCInterface, ObjCProtocol], + ErrorDiag, "ExpectedType">; + let Documentation = [SwiftBridgeDocs];

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2133 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; Is this a type or a declaration attribute? It looks like a declaration attribute based on the

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: clang. compnerd requested review of this revision. This extends semantic analysis of attributes for Swift interoperability by introducing the `swift_bridge` attribute. This attribute enables