This revision was automatically updated to reflect the committed changes.
Closed by commit rG9218f9283802: [clang][aarch64] ACLE: Support implicit casts
between GNU and SVE vectors (authored by c-rhodes).
Changed prior to commit:
https://reviews.llvm.org/D87607?vs=292162=292441#toc
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87607/new/
https://reviews.llvm.org/D87607
___
cfe-commits mailing list
c-rhodes added inline comments.
Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:237
+// Test implicit conversion between SVE and GNU vector is invalid when
+// __ARM_FEATURE_SVE_BITS != N
+#if defined(__ARM_FEATURE_SVE_BITS) && __ARM_FEATURE_SVE_BITS == 512
c-rhodes updated this revision to Diff 292162.
c-rhodes added a comment.
Address comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87607/new/
https://reviews.llvm.org/D87607
Files:
clang/lib/AST/ASTContext.cpp
clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c
c-rhodes added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:8522
+ return VT->getElementType().getCanonicalType() ==
+ getBuiltinVectorTypeInfo(BT).ElementType;
}
efriedma wrote:
> c-rhodes wrote:
> > efriedma wrote:
efriedma added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:8522
+ return VT->getElementType().getCanonicalType() ==
+ getBuiltinVectorTypeInfo(BT).ElementType;
}
c-rhodes wrote:
> efriedma wrote:
> > We allow casting
c-rhodes added inline comments.
Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:233-234
+svint64_t to_svint64_t__from_gnu_int32_t(gnu_int32_t x) { return x; } //
expected-error-re {{returning 'gnu_int32_t' (vector of {{[0-9]+}} 'int32_t'
values) from a function with
c-rhodes added inline comments.
Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:233-234
+svint64_t to_svint64_t__from_gnu_int32_t(gnu_int32_t x) { return x; } //
expected-error-re {{returning 'gnu_int32_t' (vector of {{[0-9]+}} 'int32_t'
values) from a function with
c-rhodes updated this revision to Diff 291891.
c-rhodes edited the summary of this revision.
c-rhodes added a comment.
Added tests for implicit casts between GNU and fixed-length SVE vectors. I was
planning to create a separate patch for this but since it's only tests and no
functional changes
c-rhodes added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:8522
+ return VT->getElementType().getCanonicalType() ==
+ getBuiltinVectorTypeInfo(BT).ElementType;
}
efriedma wrote:
> We allow casting SVE fixed-width
efriedma added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:8522
+ return VT->getElementType().getCanonicalType() ==
+ getBuiltinVectorTypeInfo(BT).ElementType;
}
We allow casting SVE fixed-width vectors only if the
c-rhodes created this revision.
c-rhodes added reviewers: sdesmalen, efriedma, rsandifo-arm.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: clang.
c-rhodes requested review of this revision.
This patch adds support for implicit
12 matches
Mail list logo