[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

dblaikie added a comment. In D87673#2290926 , @sammccall wrote: > In D87673#2290838 , @dblaikie wrote: > >> In D87673#2275940 , @sammccall >> wrote: >> >>> Thanks, this seem

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

sammccall added a comment. In D87673#2290838 , @dblaikie wrote: > In D87673#2275940 , @sammccall wrote: > >> Thanks, this seems better than crashing. >> The practical result isn't wonderful: the two are going to fig

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

dblaikie added a comment. In D87673#2275940 , @sammccall wrote: > Thanks, this seems better than crashing. > The practical result isn't wonderful: the two are going to fight over index > files to some extent. But this can happen with different clangd vers

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd427df6369f1: [clangd] Don't use zlib when it's unavailable. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

sammccall accepted this revision. sammccall added a comment. Thanks, this seems better than crashing. The practical result isn't wonderful: the two are going to fight over index files to some extent. But this can happen with different clangd versions (that use different index format versions) an

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX updated this revision to Diff 292116. ArcsinX added a comment. Remove {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 Files: clang-tools-extra/clangd/index/Serialization.cpp Index: clang-tool

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:209 Uncompressed = UncompressedStorage; + } else { +return error("Compressed string table, but zlib

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX updated this revision to Diff 291827. ArcsinX added a comment. Fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 Files: clang-tools-extra/clangd/index/Serialization.cpp Index: clang-tool

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX added reviewers: sammccall, kadircet, adamcz. ArcsinX added a comment. Unsure about test for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 ___ cfe-

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch `clangd` crashes at try to load co