This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc894bfd1f580: [clangd] Add option for disabling AddUsing
tweak on some namespaces. (authored by adamcz).
Changed prior to commit:
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/Config.h:70
+// declarations, always spell out the whole name (with or without leading
+// ::). All nested namespaces are affected as well.
+std::vector FullyQualifiedNamespaces;
adamcz updated this revision to Diff 292786.
adamcz marked 2 inline comments as done.
adamcz added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87775/new/
https://reviews.llvm.org/D87775
Files:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Can we add a simple test to TweakTests (I should really split up that file)
and to ConfigCompileTests?
(BTW, do you think we should merge Config{Compile,YAML}Tests?
adamcz updated this revision to Diff 292521.
adamcz marked 5 inline comments as done.
adamcz added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87775/new/
https://reviews.llvm.org/D87775
Files:
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/ConfigFragment.h:167
+ struct StyleBlock {
+// List of namespaces that should not appear in "using" declarations.
+std::vector> FullyQualifiedNamespaces;
sammccall wrote:
> Can we
sammccall added a comment.
Nice!
Comment at: clang-tools-extra/clangd/Config.h:66
+
+ /// Style of the codebase.
+ struct {
describe elements more precisely?
They are namespaces with/without leading/trailing ::, and sub-namespaces are
implicitly included.
adamcz created this revision.
adamcz added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
adamcz requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
For style guides forbid
