[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 305978. LuoYuanke added a comment. Address Wei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/include/llvm/CodeGen/LiveRegMatrix.h:44 VirtRegMap *VRM; + MachineRegisterInfo *MRI; wxiao3 wrote: > what's the purpose of this member? It is useless. Thanks. Comment at:

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added a comment. Please add register allocation code owner: "qcolombet" to the reviewer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 ___

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added inline comments. Comment at: llvm/include/llvm/CodeGen/LiveRegMatrix.h:44 VirtRegMap *VRM; + MachineRegisterInfo *MRI; what's the purpose of this member? Comment at: llvm/lib/Target/X86/X86RegisterInfo.cpp:917 + } + for

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 305345. LuoYuanke added a comment. Rename type name __tile to __tile1024i. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files:

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/statepoint-fixup-invoke.mir:94 ; CHECK: ADJCALLSTACKDOWN64 0, 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp - ; CHECK: STATEPOINT 0, 0, 1,

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 304736. LuoYuanke added a comment. Fix clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 304703. LuoYuanke added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr *NewMI = LuoYuanke wrote:

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 304136. LuoYuanke added a comment. Config palette. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 303833. LuoYuanke added a comment. Reformt the code with lint fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files:

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke marked 5 inline comments as done. LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 303830. LuoYuanke added a comment. 1. Address Pengfei's comments. 2. Add tilerelease at the epilog. 3. Fix a bug of emitting instruction that use subregister. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/X86/amx_api.c:13 + //CHECK-LABEL: @test_api + //CHECK: call <256 x i32> @llvm.x86.tileloadd64.internal + //CHECK: call <256 x i32> @llvm.x86.tdpbssd.internal pengfei wrote: > Shoud it check for 3

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added a comment. In D87981#2379249 , @akashk4 wrote: > It would be great if TILE_RELEASE is supported in the backend, so the scope > of transaction is known and the configurations are at least stored to memory > properly. TILERELEASE don't

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr *NewMI = akashk4 wrote: >

[PATCH] D87981: [X86] AMX programming model prototype.

akashk4 requested changes to this revision. akashk4 added a comment. This revision now requires changes to proceed. It would be great if TILE_RELEASE is supported in the backend, so the scope of transaction is known and the configurations are at least stored to memory properly.

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 303345. LuoYuanke added a comment. Fix lit test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

pengfei added a comment. You may still need to change the format according to the Lint suggestions. Comment at: clang/lib/Headers/amxintrin.h:227 + +/// This is new intrinsic interface +typedef int _tile_data __attribute__((__vector_size__(1024), __aligned__(64)));

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/ipra-reg-usage.ll:6 define preserve_allcc void @foo()#0 { -; CHECK: foo Clobbered Registers: $cs $df $ds $eflags $eip $eiz $es $fpcw $fpsw $fs $gs $hip $ip $mxcsr $rip $riz $ss $ssp $bnd0 $bnd1 $bnd2 $bnd3 $cr0

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 302738. LuoYuanke added a comment. Removed tilezero support in this patch. Fixed some bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files:

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke marked an inline comment as done. LuoYuanke added inline comments. Comment at: clang/lib/Headers/amxintrin.h:259 +__DEFAULT_FN_ATTRS +void __tile_loadd(__tile *dst, const void *base, long stride) { + dst->tile = _tile_loadd_internal(dst->row, dst->col, base, stride);

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 301205. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/include/llvm/CodeGen/TileShapeInfo.h:9 +// +// This file defines TileShapeInfo for AMX. +// pengfei wrote: > Do you want to use `TileShapeInfo` for the class name or forget to change the > comment to `ShapeT`? I

[PATCH] D87981: [X86] AMX programming model prototype.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:259 +__DEFAULT_FN_ATTRS +void __tile_loadd(__tile *dst, const void *base, long stride) { + dst->tile = _tile_loadd_internal(dst->row, dst->col, base, stride); unsigned long long?

[PATCH] D87981: [X86] AMX programming model prototype.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:69 +#undef __DEFAULT_FN_ATTRS + Better to use `__DEFAULT_FN_ATTRS_TILE`, `__DEFAULT_FN_ATTRS_INT8`, then you don't need to undef it in the middle. Comment at:

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 301172. LuoYuanke added a comment. Herald added a subscriber: dexonsmith. Rebase and Model tile configure register. Configure register is the user of all the amx instruction. Add X86PreTileConfig pass to insert psuedo ldtilecfg and build the data depenedcy

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 298546. LuoYuanke added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 296050. LuoYuanke added a comment. Herald added a subscriber: pengfei. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files:

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 294036. LuoYuanke added a comment. Updating D87981 : [X86] AMX programming model prototype. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 293362. LuoYuanke added a comment. Updating D87981 : [X86] AMX programming model prototype. Fix clang format and add test case for RA that across function call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 293051. LuoYuanke added a comment. Herald added a subscriber: nikic. Updating D87981 : [X86] AMX programming model prototype. Fixed lit test case failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 293007. LuoYuanke added a comment. Updating D87981 : [X86] AMX programming model prototype. Fixed some clang format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny, qcolombet, MatzeB. Herald added projects: clang, LLVM. LuoYuanke requested review of this revision. Herald added a subscriber: jdoerfert. Change-Id: I935e1080916ffcb72af54c2c83faa8b2e97d5cb0