[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. I created D89204 which hopefully fixes Sony's issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88363/new/ https://reviews.llvm.org/D88363

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. In D88363#2319242 , @bdf wrote: > In D88363#2319157 , @jmorse wrote: > >> In D88363#2317241 , @Mordante wrote: >> >>> Can you explain the kind of

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

bdf added a comment. In D88363#2319157 , @jmorse wrote: > In D88363#2317241 , @Mordante wrote: > >> Can you explain the kind of issues you're having? > > At the shallowest level, our -O1 produces different IR and

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

jmorse added a comment. In D88363#2317241 , @Mordante wrote: > Can you explain the kind of issues you're having? At the shallowest level, our -O1 produces different IR and fails the test, which is more or less our problem; however my understanding is

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. In D88363#2312129 , @jmorse wrote: > Hi -- We (Sony) are running into a bit of difficulty with the test for this > change, as it relies on the configuration of the -O1 optimisation pipeline. > Would it be possible to reduce

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

jmorse added a comment. Hi -- We (Sony) are running into a bit of difficulty with the test for this change, as it relies on the configuration of the -O1 optimisation pipeline. Would it be possible to reduce down to a frontend test, and then tests for whatever passes are to interpret the IR

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rG1113fbf44c22: [CodeGen] Improve likelihood branch weights (authored by Mordante). Changed prior to

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM modulo comment nits. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1622 EmitBranchOnBoolExpr(CondOp->getCond(), LHSBlock, RHSBlock, - getProfileCount(CondOp), Weights); +

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1622 EmitBranchOnBoolExpr(CondOp->getCond(), LHSBlock, RHSBlock, - getProfileCount(CondOp), Weights); +

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1622 EmitBranchOnBoolExpr(CondOp->getCond(), LHSBlock, RHSBlock, - getProfileCount(CondOp), Weights); + getProfileCount(CondOp),

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

bdf accepted this revision. bdf added a comment. This revision is now accepted and ready to land. Looks good. Good idea to add tests to verify that we match `__builtin_except()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88363/new/

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman. Mordante added a project: clang. Mordante requested review of this revision. Bruno De Fraine discovered some issues with D85091 . The branch weights generated for `logical not` and