This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5509748f2ce5: [cfe][driver][M68k](8/8) Clang driver support
(authored by myhsu).
Changed prior to commit:
myhsu updated this revision to Diff 327029.
myhsu marked 4 inline comments as done.
myhsu added a comment.
[NFC] Update FileCheck prefix
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
Files:
clang/include/clang/Driver/Options.td
glaubitz added inline comments.
Comment at: clang/test/Driver/m68k-sub-archs.cpp:1
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck
--check-prefix=CHECK-MX00 %s
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 |
FileCheck
jrtc27 added inline comments.
Comment at: clang/test/Driver/m68k-sub-archs.cpp:1
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck
--check-prefix=CHECK-MX00 %s
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 |
FileCheck
glaubitz added inline comments.
Comment at: clang/test/Driver/m68k-sub-archs.cpp:1
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck
--check-prefix=CHECK-MX00 %s
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 |
FileCheck
jrtc27 added inline comments.
Comment at: clang/test/Driver/m68k-sub-archs.cpp:1
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck
--check-prefix=CHECK-MX00 %s
+// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 |
FileCheck
myhsu marked an inline comment as done.
myhsu added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:380
ve::getVETargetFeatures(D, Args, Features);
+break;
}
jrtc27 wrote:
> jrtc27 wrote:
> > Unrelated
> I committed this as
myhsu updated this revision to Diff 326506.
myhsu marked 3 inline comments as done.
myhsu added a comment.
- Addressed feedbacks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
Files:
clang/include/clang/Driver/Options.td
jrtc27 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:380
ve::getVETargetFeatures(D, Args, Features);
+break;
}
jrtc27 wrote:
> Unrelated
I committed this as 22215e492338, should disappear if you rebase (or you can
just
jrtc27 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:380
ve::getVETargetFeatures(D, Args, Features);
+break;
}
Unrelated
Comment at: clang/test/Driver/m68k-sub-archs.cpp:1
+// RUN: %clang -### -target
myhsu added inline comments.
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2101
+ static const char *const M68kLibDirs[] = {"/lib"};
+ static const char *const M68kTriples[] = {
MaskRay wrote:
> The second `const ` is redundant
I don't think so...first,
myhsu updated this revision to Diff 320586.
myhsu marked 5 inline comments as done.
myhsu added a comment.
Herald added a reviewer: jansvoboda11.
- Addressed feedbacks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
Files:
rengolin added inline comments.
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2089
+ static const char *const M68kTriples[] = {
+ "m68k-linux-gnu", "m68k-unknown-linux-gnu", "m68k-suse-linux"};
+
jrtc27 wrote:
> rengolin wrote:
> > The front-end supports
jrtc27 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2089
+ static const char *const M68kTriples[] = {
+ "m68k-linux-gnu", "m68k-unknown-linux-gnu", "m68k-suse-linux"};
+
rengolin wrote:
> The front-end supports FreeBSD, too.
MaskRay accepted this revision.
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/M68k.h:38
+} // end namespace m68k
+} // namespace tools
+} // end namespace driver
mismatching `end` and no `end`?
clang-format seems to drop `end`. I
rengolin accepted this revision.
rengolin added a comment.
LGTM too, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM, it would be great if someone else stamps this too, in case I missed
something.
Comment at: clang/include/clang/Driver/Options.td:164
+def m_m68k_Features_Group:
myhsu updated this revision to Diff 310755.
myhsu marked an inline comment as done.
myhsu added a comment.
- [NFC] Fix minor formatting
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
Files:
clang/include/clang/Driver/Options.td
rengolin added inline comments.
Comment at: clang/include/clang/Driver/Options.td:164
+def m_m68k_Features_Group: OptionGroup<"">,
+ Group, DocName<"M68k">;
def m_mips_Features_Group : OptionGroup<"">,
craig.topper wrote:
> bruno
craig.topper added inline comments.
Comment at: clang/include/clang/Driver/Options.td:164
+def m_m68k_Features_Group: OptionGroup<"">,
+ Group, DocName<"M68k">;
def m_mips_Features_Group : OptionGroup<"">,
bruno wrote:
> Looks like
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: clang/include/clang/Driver/Options.td:164
+def m_m68k_Features_Group: OptionGroup<"">,
+ Group, DocName<"M68k">;
def m_mips_Features_Group : OptionGroup<"">,
myhsu marked 2 inline comments as done.
myhsu added inline comments.
Comment at: clang/include/clang/Driver/Options.td:3125
+foreach i = {0-4} in
+ def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group;
myhsu wrote:
> bruno wrote:
> > rengolin wrote:
> > > Same
myhsu updated this revision to Diff 309462.
myhsu added a comment.
- Add support for M68060 sub-target
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/CMakeLists.txt
myhsu added inline comments.
Comment at: clang/include/clang/Driver/Options.td:3125
+foreach i = {0-4} in
+ def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group;
bruno wrote:
> rengolin wrote:
> > Same question as @RKSimon had below: Shouldn't this cover all
myhsu updated this revision to Diff 308551.
myhsu marked 11 inline comments as done.
myhsu added a comment.
- Rebased to latest changes
- Addressed some of the feedbacks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
Files:
bruno added inline comments.
Comment at: clang/include/clang/Driver/Options.td:3125
+foreach i = {0-4} in
+ def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group;
rengolin wrote:
> Same question as @RKSimon had below: Shouldn't this cover all models the
> back-end
RKSimon added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/M68k.cpp:51
+}
+return CPUName.str();
+ }
Can't we just use StringSwitch here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
rengolin added inline comments.
Comment at: clang/include/clang/Driver/Options.td:3125
+foreach i = {0-4} in
+ def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group;
Same question as @RKSimon had below: Shouldn't this cover all models the
back-end recognises?
RKSimon added a comment.
Some very minor nits - the 68060 omission is the biggest one (apple might not
have used it but commodore did!)
Comment at: clang/include/clang/Driver/Options.td:155
+def m_m68k_Features_Group: OptionGroup<"">,
+ Group,
myhsu updated this revision to Diff 302188.
myhsu retitled this revision from "[Driver][M68K] (Patch 8/8) Add driver
support for M68K" to "[Driver][M68k] (Patch 8/8) Add driver support for M68k".
myhsu edited the summary of this revision.
myhsu added a comment.
[NFC] Rename M680x0 to M68k
myhsu updated this revision to Diff 296065.
myhsu added a comment.
- Use the canonical CPU name (i.e. names started with upper case 'M')
- Tell the driver to use integrated assembler (i.e. MC) by default
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
myhsu updated this revision to Diff 295469.
myhsu added a reviewer: aaron.ballman.
myhsu added a comment.
Fix formatting issues
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88394/new/
https://reviews.llvm.org/D88394
Files:
clang/include/clang/Driver/Options.td
myhsu created this revision.
Herald added subscribers: cfe-commits, dang, mgorny.
Herald added a project: clang.
myhsu requested review of this revision.
Herald added a subscriber: ormris.
Add new toolchain and driver options for the M680x0 target
Repository:
rG LLVM Github Monorepo
33 matches
Mail list logo
