This revision was automatically updated to reflect the committed changes.
Closed by commit rGfcf680050686: [Driver] Move detectLibcxxIncludePath to
ToolChain (authored by phosek).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88452/new/
phosek updated this revision to Diff 334297.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88452/new/
https://reviews.llvm.org/D88452
Files:
clang/include/clang/Driver/ToolChain.h
clang/lib/Driver/ToolChain.cpp
phosek updated this revision to Diff 296813.
Herald added a subscriber: ormris.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88452/new/
https://reviews.llvm.org/D88452
Files:
clang/include/clang/Driver/ToolChain.h
clang/lib/Driver/ToolChain.cpp
thakis added a comment.
On
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867483277057489840/+/steps/package_clang/0/stdout?format=raw
too. Reverted in ba60dc0aa75e86165e260b2c08afafd1c394e95a
thakis added a comment.
Breaks tests on windows: http://45.33.8.238/win/25123/step_7.txt
Please take a look, and revert if it takes a while to fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88452/new/
https://reviews.llvm.org/D88452
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa594fd28e373: [Driver] Move detectLibcxxIncludePath to
ToolChain (authored by phosek).
Changed prior to commit:
phosek created this revision.
phosek added reviewers: kristina, leonardchan.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
phosek requested review of this revision.
This helper method is useful even outside of Gnu toolchains, so move
it to ToolChain so it can be reused in
