This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb764edc59ff7: [clangd] Try harder to get accurate ranges for
documentSymbols in macros (authored by nridge).
Repository:
rG LLVM Github Monorepo
nridge updated this revision to Diff 297712.
nridge marked 2 inline comments as done.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88463/new/
https://reviews.llvm.org/D88463
Files:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks! This seems totally complete now, though I bet there's another case
possible somehow!
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:157
+
nridge added a reviewer: sammccall.
nridge added a comment.
Sam, perhaps you could have a look at this? It involves tricky macro location
stuff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88463/new/
https://reviews.llvm.org/D88463
nridge created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
nridge requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Fixes https://github.com/clangd/clangd/issues/500
Repository:
rG LLVM
