hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1120
namespace ns { class [[Foo]] {}; }
- using ns::F^oo;
+ using ns::[[F^oo]];
)cpp",
sammccall wrote:
> hokein wrote:
> > this seems a small
hokein updated this revision to Diff 295238.
hokein added a comment.
refine the patch based on the offline discussion:
- don't set the Underlying bits for using-declaration's underlying decl.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall added a comment.
We manage to get rid of a little code here, but we add complexity to an
important API, and make... one test better and a few tests worse.
I'd like to get rid of the wart in the code, but the tradeoff doesn't seem
completely compelling... going to think about the API
hokein added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.h:112
+ /// Underlying declarations for renaming alias (typedef decl, type alias
decl)
+ AliasUnderlying,
+ /// Underlying declarations for non-renaming alias, decltype, etc.
The
hokein created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Extend the TargetDecl API to fix the workaround in
