This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf24649b77d85: [clangd] Don't set the Underlying bit on
targets of UsingDecls. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES S
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1121
namespace ns { class [[Foo]] {}; }
- using ns::F^oo;
+ using ns::[[F^oo]];
)cpp",
sammccall wrote:
> I'd like to make a plan to solve this regre
hokein updated this revision to Diff 296612.
hokein marked 2 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88472/new/
https://reviews.llvm.org/D88472
Files:
clang-tools-extra/cla
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG, thanks for all the iterations here.
I do want to solve the regression but we can land without that.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:345
}
