[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a3cbb1535a9: [clangd] Add basic keyword-name-validation in rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:416 +auto Results = clangd::rename( +{Pos, /*NewName=*/"__clangd_rename_dummy", InpAST->AST, File, + RenameOpts.AllowCrossFile ? nullptr : Index, RenameOpts});

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:416 +auto Results = clangd::rename( +{Pos, /*NewName=*/"__clangd_rename_dummy", InpAST->AST, File,

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:124 + + // name validation. + RenameToKeywords, sammccall wrote: > nit: not sure we need a separate section for these, I can imagine at most > keyword/conflict/shadow yeah,

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein updated this revision to Diff 296438. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88875/new/ https://reviews.llvm.org/D88875 Files: clang-tools-extra/cla

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:124 + + // name validation. + RenameToKeywords, nit: not sure we need a separate section for these, I can imagine at most keyword/conflict/shadow Comme

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://revie