[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder abandoned this revision. scott.linder added a comment. I'll open a new review as part of upstreaming all of the debug info work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a subscriber: arichardson. Please rebase if still relevant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

arsenm added a comment. Herald added a project: All. Is this still needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978 ___ cfe-commits mailing list

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. In D88978#2660274 , @arsenm wrote: > Is this still needed? Yes, I just got a little bogged down in the OMP code and haven't gotten back to it to finish it up. I anticipate needing to do this to soon, though. Repository:

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

arsenm added a comment. Is this still needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

ABataev added a comment. In D88978#2343484 , @jdoerfert wrote: > I have no idea what from the commit message what this has to do with the > OpenMP code gen but I saw this randomly while looking for something else so > here we go: > > In D88978#2326036

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

jdoerfert added a comment. I have no idea what from the commit message what this has to do with the OpenMP code gen but I saw this randomly while looking for something else so here we go: In D88978#2326036 , @scott.linder wrote: > In D88978#2325991

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. In D88978#2325991 , @ABataev wrote: > In D88978#2325982 , @scott.linder > wrote: > >> @ABataev Sorry if I'm pulling you in without enough context/work on my end, >> but I wanted to

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

ABataev added a comment. In D88978#2325982 , @scott.linder wrote: > @ABataev Sorry if I'm pulling you in without enough context/work on my end, > but I wanted to ask how the Clang codegen for OpenMP locals works at a high > level? > > Is the idea that

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. @ABataev Sorry if I'm pulling you in without enough context/work on my end, but I wanted to ask how the Clang codegen for OpenMP locals works at a high level? Is the idea that instead of an `alloc` the frontend can insert calls into the runtime in some cases, like

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1579 if (EmitDebugInfo && HaveInsertPoint()) { -Address DebugAddr = address; +Address DebugAddr = AllocaAddr.isValid() ? AllocaAddr : address; bool UsePointerValue = NRVO &&

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1579 if (EmitDebugInfo && HaveInsertPoint()) { -Address DebugAddr = address; +Address DebugAddr = AllocaAddr.isValid() ? AllocaAddr : address; bool UsePointerValue = NRVO &&

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. I need to add more tests, but I wanted to float the idea of the change and get feedback first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. scott.linder requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. A dbg.declare for a local/parameter describes the hardware location