[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

2020-11-12 Thread Kevin P. Neal via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGac523d2de51c: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict… (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

2020-11-12 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88987/new/ https://reviews.llvm.org/D88987 ___ cfe-commits mailing list

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

2020-11-11 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn updated this revision to Diff 304557. kpn added a comment. Update for review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88987/new/ https://reviews.llvm.org/D88987 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

2020-11-11 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. No worries! The option does already have tests that verify correct operation. Comment at: clang/include/clang/Driver/Options.td:1286 + HelpText<"Enables experimental strict floating point in LLVM.">, + MarshallingInfoFlag<"LangOpts->ExpStrictFP",

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

2020-11-10 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. Hi Kevin, sorry for the late response. I don't think adding new tests is necessary as long as the flag is used in existing ones. Comment at:

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

2020-10-26 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88987/new/ https://reviews.llvm.org/D88987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

2020-10-07 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn created this revision. kpn added a reviewer: dang. kpn added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. kpn requested review of this revision. As of D80952 we are disabling strict floating point on all hosts except those that are