ldionne added a comment.
I just did some digging. We completed the transition to the
libcxx-headers-in-the-SDK already, and now upstream and downstream Clang are
the same with respect to those search paths. I think it might just be the case
that you need the very latest AppleClang for that to
dexonsmith added a comment.
SGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89001/new/
https://reviews.llvm.org/D89001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DmitryPolukhin added a comment.
@dexonsmith thank you for quick response. I think we need to update upstream
behaviour to match system compiler behaviour otherwise clang-tools that uses
path to compiler binary form CDB will not work as expected and extra options
won't help much because it is
dexonsmith added a comment.
I don't have access to rdar these days to look into the current state or to
refresh my memory.
My memory is that the high-level goal was to move the libc++ headers from the
toolchain to the SDK. For the transition, this was staged in such a way that
they were in
DmitryPolukhin added a comment.
Herald added a subscriber: MaskRay.
Herald added a project: All.
@ldionne and @dexonsmith, it seems that this diff breaks clang-tools like
clang-tidy and clangd if `-isysroot` is specified in the compilation database.
Moreover, clang from Xcode 14 and 15 uses
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa3a24316087d: [clang] Dont look into sysroot
for C++ headers if they are found alongside… (authored by ldionne).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ldionne updated this revision to Diff 297000.
ldionne added a comment.
Try to fix test failure on Linux
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89001/new/
https://reviews.llvm.org/D89001
Files:
clang/lib/Driver/ToolChains/Darwin.cpp
ldionne created this revision.
ldionne added reviewers: arphaman, dexonsmith.
Herald added subscribers: cfe-commits, jkorous.
Herald added a project: clang.
ldionne requested review of this revision.
Currently, Clang looks for libc++ headers alongside the installation
directory of Clang, and it
