[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

2020-10-08 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfbb499ef255b: [AST] Fix crashes caused by redeclarations in hidden prototypes (authored by bnbarham, committed by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

2020-10-08 Thread Ben Barham via Phabricator via cfe-commits
bnbarham updated this revision to Diff 297098. bnbarham added a comment. Removed platform-specific path separator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024 Files: clang/lib/AST/DeclObjC.cpp clang/test/Index/Inputs/hidden-redecls-sub.h

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

2020-10-07 Thread Ben Barham via Phabricator via cfe-commits
bnbarham updated this revision to Diff 296861. bnbarham added a comment. Update test to include explicit OSX target triple CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024 Files: clang/lib/AST/DeclObjC.cpp

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

2020-10-07 Thread Ben Barham via Phabricator via cfe-commits
bnbarham updated this revision to Diff 296859. bnbarham added a comment. Ran clang-format again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024 Files: clang/lib/AST/DeclObjC.cpp clang/test/Index/Inputs/hidden-redecls-sub.h

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

2020-10-07 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

2020-10-07 Thread Ben Barham via Phabricator via cfe-commits
bnbarham created this revision. bnbarham added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, arphaman, dexonsmith. Herald added a project: clang. bnbarham requested review of this revision. ObjCContainerDecl.getMethod returns a nullptr by default when the container is a hidden